]> git.ipfire.org Git - thirdparty/kernel/stable.git/commit
bus: mhi: ep: Update read pointer only after buffer is written
authorSumit Kumar <quic_sumk@quicinc.com>
Wed, 9 Apr 2025 10:47:43 +0000 (16:17 +0530)
committerManivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
Thu, 24 Apr 2025 05:04:51 +0000 (10:34 +0530)
commit6f18d174b73d0ceeaa341f46c0986436b3aefc9a
treea9c6eff39fff61e2a744095346cb6e0623460a8a
parent0af2f6be1b4281385b618cb86ad946eded089ac8
bus: mhi: ep: Update read pointer only after buffer is written

Inside mhi_ep_ring_add_element, the read pointer (rd_offset) is updated
before the buffer is written, potentially causing race conditions where
the host sees an updated read pointer before the buffer is actually
written. Updating rd_offset prematurely can lead to the host accessing
an uninitialized or incomplete element, resulting in data corruption.

Invoke the buffer write before updating rd_offset to ensure the element
is fully written before signaling its availability.

Fixes: bbdcba57a1a2 ("bus: mhi: ep: Add support for ring management")
cc: stable@vger.kernel.org
Co-developed-by: Youssef Samir <quic_yabdulra@quicinc.com>
Signed-off-by: Youssef Samir <quic_yabdulra@quicinc.com>
Signed-off-by: Sumit Kumar <quic_sumk@quicinc.com>
Reviewed-by: Jeff Hugo <jeff.hugo@oss.qualcomm.com>
Reviewed-by: Krishna Chaitanya Chundru <krishna.chundru@oss.qualcomm.com>
Reviewed-by: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
Link: https://patch.msgid.link/20250409-rp_fix-v1-1-8cf1fa22ed28@quicinc.com
Signed-off-by: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
drivers/bus/mhi/ep/ring.c