]> git.ipfire.org Git - thirdparty/openvpn.git/commit
Avoid illegal memory access when malformed data is read from the pipe
authorSelva Nair <selva.nair@gmail.com>
Fri, 20 Oct 2017 17:25:56 +0000 (13:25 -0400)
committerGert Doering <gert@greenie.muc.de>
Fri, 3 Nov 2017 18:21:06 +0000 (19:21 +0100)
commit6f20808c8f37301c43d822f6a22d30b3587abc57
tree36f5e369babc2b36208c376ed1922fce9333defb
parenta5d73667ffebea93960c135322aa3a8d0fd70d7a
Avoid illegal memory access when malformed data is read from the pipe

- If only 1 byte is read from the interactive service client pipe, that
  evaluates to zero wide characters and subsequent check for NUL
  termination in the data buffer segfaults.
  Fix: reject clients that send less than a complete wide character.

Signed-off-by: Selva Nair <selva.nair@gmail.com>
Acked-by: Gert Doering <gert@greenie.muc.de>
Message-Id: <1508520356-18277-1-git-send-email-selva.nair@gmail.com>
URL: https://www.mail-archive.com/openvpn-devel@lists.sourceforge.net/msg15657.html
Signed-off-by: Gert Doering <gert@greenie.muc.de>
src/openvpnserv/interactive.c