]> git.ipfire.org Git - thirdparty/linux.git/commit
ALSA: seq: Clear variable event pointer on read
authorKyle Zeng <kylebot@openai.com>
Sun, 7 Jun 2026 00:41:29 +0000 (17:41 -0700)
committerTakashi Iwai <tiwai@suse.de>
Sun, 7 Jun 2026 07:24:16 +0000 (09:24 +0200)
commit705dd6dcbc0ea87351c660c1a6443f85f1001c76
tree4609a3420746ddff6d04ca66173a8671ef4f6ba2
parent98fe3988a2efe89a1a1ded213a0561e6543e94e2
ALSA: seq: Clear variable event pointer on read

snd_seq_read() copies a queued variable-length event header to userspace
before expanding the payload. Queued variable-length events use
SNDRV_SEQ_EXT_CHAINED internally, and data.ext.ptr points at the first
extension cell.

The read side strips SNDRV_SEQ_EXT_* bits from data.ext.len before the
copy, but it leaves data.ext.ptr untouched. A userspace sequencer client
can therefore write a direct variable event to itself and read back the
extension-cell kernel address from the returned header.

Clear the temporary header pointer before copy_to_user(). The original
queued event remains unchanged and is still passed to
snd_seq_expand_var_event(), so payload expansion keeps using the
internal chain.

Fixes: 1da177e4c3f4 ("Linux-2.6.12-rc2")
Signed-off-by: Kyle Zeng <kylebot@openai.com>
Link: https://patch.msgid.link/20260607004129.61345-1-kylebot@openai.com
Signed-off-by: Takashi Iwai <tiwai@suse.de>
sound/core/seq/seq_clientmgr.c