]> git.ipfire.org Git - thirdparty/kernel/stable.git/commit
RDMA/rxe: Validate pad and ICRC before payload_size() in rxe_rcv
authorhkbinbin <hkbinbinbin@gmail.com>
Wed, 1 Apr 2026 12:19:07 +0000 (12:19 +0000)
committerJason Gunthorpe <jgg@nvidia.com>
Thu, 9 Apr 2026 14:18:21 +0000 (11:18 -0300)
commit7244491dab347f648e661da96dc0febadd9daec3
tree201049c90c8dcc369f432bde43f602129e9520e1
parent6ed3d14fc45d3da6025e7fe4a6a09066856698e2
RDMA/rxe: Validate pad and ICRC before payload_size() in rxe_rcv

rxe_rcv() currently checks only that the incoming packet is at least
header_size(pkt) bytes long before payload_size() is used.

However, payload_size() subtracts both the attacker-controlled BTH pad
field and RXE_ICRC_SIZE from pkt->paylen:

  payload_size = pkt->paylen - offset[RXE_PAYLOAD] - bth_pad(pkt)
                 - RXE_ICRC_SIZE

This means a short packet can still make payload_size() underflow even
if it includes enough bytes for the fixed headers. Simply requiring
header_size(pkt) + RXE_ICRC_SIZE is not sufficient either, because a
packet with a forged non-zero BTH pad can still leave payload_size()
negative and pass an underflowed value to later receive-path users.

Fix this by validating pkt->paylen against the full minimum length
required by payload_size(): header_size(pkt) + bth_pad(pkt) +
RXE_ICRC_SIZE.

Cc: stable@vger.kernel.org
Fixes: 8700e3e7c485 ("Soft RoCE driver")
Link: https://patch.msgid.link/r/20260401121907.1468366-1-hkbinbinbin@gmail.com
Signed-off-by: hkbinbin <hkbinbinbin@gmail.com>
Reviewed-by: Zhu Yanjun <yanjun.zhu@linux.dev>
Signed-off-by: Jason Gunthorpe <jgg@nvidia.com>
drivers/infiniband/sw/rxe/rxe_recv.c