]> git.ipfire.org Git - thirdparty/libvirt.git/commit
Fix USB model defaults for ppc64
authorMartin Kletzander <mkletzan@redhat.com>
Thu, 7 Jan 2016 15:14:58 +0000 (16:14 +0100)
committerMartin Kletzander <mkletzan@redhat.com>
Sat, 9 Jan 2016 17:39:17 +0000 (18:39 +0100)
commit8156493d8db95de91dd9ace743df0fd4dff98281
tree464706c228cddb817a5519c3f1246cc002398fd7
parentaea47e48c473ac4c29e6b85960ee2be017cf2a0a
Fix USB model defaults for ppc64

The condition was checking for UHCI (and OHCI for ppc64) availability so
that it can specify the proper device instead of legacy usb.  However,
for ppc64, we don't need to check both OHCI and UHCI, but only OHCI as
that is the legacy default.  The condition is so big that it was just a
matter of time when someone will make a mistake there, so let's use more
lines so that it is visible what the condition checks for.

This fixes usage of -device instead of -usb for ppc64 that supports
pci-usb-ohci and does not support piix3-usb-uhci.

Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=1297020

Signed-off-by: Martin Kletzander <mkletzan@redhat.com>
src/qemu/qemu_command.c
tests/qemuxml2argvdata/qemuxml2argv-ppc64-usb-controller-legacy.args [new file with mode: 0644]
tests/qemuxml2argvdata/qemuxml2argv-ppc64-usb-controller-legacy.xml [new symlink]
tests/qemuxml2argvdata/qemuxml2argv-ppc64-usb-controller.args [new file with mode: 0644]
tests/qemuxml2argvdata/qemuxml2argv-ppc64-usb-controller.xml [new file with mode: 0644]
tests/qemuxml2argvtest.c