]> git.ipfire.org Git - thirdparty/kernel/stable.git/commit
mptcp: reset blackhole on success with non-loopback ifaces
authorMatthieu Baerts (NGI0) <matttbe@kernel.org>
Thu, 18 Sep 2025 08:50:18 +0000 (10:50 +0200)
committerJakub Kicinski <kuba@kernel.org>
Fri, 19 Sep 2025 14:06:19 +0000 (07:06 -0700)
commit833d4313bc1e9e194814917d23e8874d6b651649
tree3a86cf79a7610f2286096cec19c61be4a5b8e378
parentc4bdef8b3d2a9ad4ac45017fa294b3b0784ca974
mptcp: reset blackhole on success with non-loopback ifaces

When a first MPTCP connection gets successfully established after a
blackhole period, 'active_disable_times' was supposed to be reset when
this connection was done via any non-loopback interfaces.

Unfortunately, the opposite condition was checked: only reset when the
connection was established via a loopback interface. Fixing this by
simply looking at the opposite.

This is similar to what is done with TCP FastOpen, see
tcp_fastopen_active_disable_ofo_check().

This patch is a follow-up of a previous discussion linked to commit
893c49a78d9f ("mptcp: Use __sk_dst_get() and dst_dev_rcu() in
mptcp_active_enable()."), see [1].

Fixes: 27069e7cb3d1 ("mptcp: disable active MPTCP in case of blackhole")
Cc: stable@vger.kernel.org
Link: https://lore.kernel.org/4209a283-8822-47bd-95b7-87e96d9b7ea3@kernel.org
Signed-off-by: Matthieu Baerts (NGI0) <matttbe@kernel.org>
Reviewed-by: Simon Horman <horms@kernel.org>
Reviewed-by: Kuniyuki Iwashima <kuniyu@google.com>
Link: https://patch.msgid.link/20250918-net-next-mptcp-blackhole-reset-loopback-v1-1-bf5818326639@kernel.org
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
net/mptcp/ctrl.c