]> git.ipfire.org Git - thirdparty/foundation/foundation-sites.git/commit
projects / thirdparty / foundation / foundation-sites.git / commit
? search:
summary | shortlog | log | commit | commitdiff | tree
(parent: fbb4fee) | patch
refactor: simplify & document `Magellan._updateActive()` 10906/head
authorNicolas Coden <nicolas@ncoden.fr>
Sat, 17 Feb 2018 21:40:51 +0000 (22:40 +0100)
committerNicolas Coden <nicolas@ncoden.fr>
Sat, 17 Feb 2018 21:40:51 +0000 (22:40 +0100)
commit8e817ed1015b293cd52e026e6eba54216f52f77d
tree100aa8db778fb5ae8f4ea8ff233d5f43864447adtree
parentfbb4feec6edb8b3457f4295b843e7cde4ada50cfcommit | diff
refactor: simplify & document `Magellan._updateActive()`

Changes:
* add comments
* rename variables for improved readibility
* use narrow functions instead of `_this`, and `let`/`const`
* prevent useless DOM manipulations when $active did not changed

Unit tests run, as well as visual tests
js/foundation.magellan.js diff | blob | blame | history
Mirror of https://github.com/foundation/foundation-sites.git