]> git.ipfire.org Git - thirdparty/samba.git/commit
selftest: run vfs.fruit test against a share that deletes empty resource forks
authorRalph Boehme <slow@samba.org>
Tue, 21 May 2019 12:05:04 +0000 (14:05 +0200)
committerJeremy Allison <jra@samba.org>
Thu, 23 May 2019 23:26:14 +0000 (23:26 +0000)
commit8ed9b6b457923d2353d1d18838f4a278db48c6b9
tree144db2b14f3e52ec0c5fd1fe7193b1a1ccd5a1cf
parentbb5a457f2872a383b58d62981dade322fca9b283
selftest: run vfs.fruit test against a share that deletes empty resource forks

This reveals a bug in the AppleDouble conversion code: the conversion code that
unlinks an empty resource fork AppleDouble sidecar file ("._file") gets
triggered as part of open_file_ntcreate(..., "file:AFP_AfpResource", ...):

after SMB_VFS_OPEN() has been called with O_CREAT, what created the file, we
call SMB_VFS_FSTAT() on the just created filehandle. This ends up in
ad_convert(), finds the resource fork empty and thus deletes the file.

Bug: https://bugzilla.samba.org/show_bug.cgi?id=13958

Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
selftest/knownfail.d/samba3.vfs.fruit
source3/selftest/tests.py