]> git.ipfire.org Git - thirdparty/gcc.git/commit
MIPS16: Mark $2/$3 as clobbered if GP is used
authorYunQiang Su <syq@gcc.gnu.org>
Tue, 28 May 2024 18:28:25 +0000 (02:28 +0800)
committerYunQiang Su <syq@debian.org>
Wed, 29 May 2024 17:15:41 +0000 (01:15 +0800)
commit915440eed21de367cb41857afb5273aff5bcb737
treeeb5411659827dddbace4799ae19140e9838b1be0
parent9a92e5e56a7f2b19928b8cb7634f59d9c7b2b582
MIPS16: Mark $2/$3 as clobbered if GP is used

PR Target/84790.
The gp init sequence
        li      $2,%hi(_gp_disp)
        addiu   $3,$pc,%lo(_gp_disp)
        sll     $2,16
        addu    $2,$3
is generated directly in `mips_output_function_prologue`, and does
not appear in the RTL.

So the IRA/IPA passes are not aware that $2/$3 have been clobbered,
so they may be used for cross (local) function call.

Let's mark $2/$3 clobber both:
  - Just after the UNSPEC_GP RTL of a function;
  - Just after a function call.

Reported-by: Matthias Schiffer <mschiffer@universe-factory.net>
Origin-Patch-by: Felix Fietkau <nbd@nbd.name>.
gcc
* config/mips/mips.cc(mips16_gp_pseudo_reg): Mark
MIPS16_PIC_TEMP and MIPS_PROLOGUE_TEMP clobbered.
(mips_emit_call_insn): Mark MIPS16_PIC_TEMP and
MIPS_PROLOGUE_TEMP clobbered if MIPS16 and CALL_CLOBBERED_GP.
gcc/config/mips/mips.cc