]> git.ipfire.org Git - thirdparty/sqlalchemy/sqlalchemy.git/commit
Add port comparison in __eq__() and __ne__() method to URL
authorSanjana <sanjana0796@gmail.com>
Thu, 28 Feb 2019 15:16:13 +0000 (10:16 -0500)
committerMike Bayer <mike_mp@zzzcomputing.com>
Thu, 28 Feb 2019 19:34:52 +0000 (14:34 -0500)
commit9268c320bf6ea35696951875df518286dd79ad54
treeb28587176a5ecd99f7bc1567027f863753f3fcd6
parentdc48ac54893491c5ecd64a868883a22769376e9a
Add port comparison in __eq__() and __ne__() method to URL

Comparing two objects of :class:`.URL` using ``__eq__()`` did not take port
number into consideration, two objects differing only by port number were
considered equal. Port comparison is now added in ``__eq__()`` method of
:class:`.URL`, objects differing by port number are now not equal.
Additionally, ``__ne__()`` was not implemented for :class:`.URL` which
caused unexpected result when ``!=`` was used in Python2, since there are no
implied relationships among the comparison operators in Python2.

Fixes: #4406
Closes: #4515
Pull-request: https://github.com/sqlalchemy/sqlalchemy/pull/4515
Pull-request-sha: 0f15b805f07e7fca1f82ca6c3aad98d50ea705b8

Change-Id: Iba7d224f1282dc3f4b884d1a746f2d46669f551e
doc/build/changelog/unreleased_12/4406.rst [new file with mode: 0644]
lib/sqlalchemy/engine/url.py
test/engine/test_parseconnect.py