]> git.ipfire.org Git - thirdparty/kernel/stable.git/commit
usb: gadget: f_ncm: Fix MAC assignment NCM ethernet
authorraub camaioni <raubcameo@gmail.com>
Fri, 15 Aug 2025 13:07:21 +0000 (09:07 -0400)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Sun, 17 Aug 2025 10:16:31 +0000 (12:16 +0200)
commit956606bafb5fc6e5968aadcda86fc0037e1d7548
tree0420df0c39145640f00face155d7f463d23e83d4
parent23cd838a178a81183da9db6cb3390bb540b000a5
usb: gadget: f_ncm: Fix MAC assignment NCM ethernet

This fix is already present in f_ecm.c and was never
propagated to f_ncm.c

When creating multiple NCM ethernet devices
on a composite usb gadget device
each MAC address on the HOST side will be identical.
Having the same MAC on different network interfaces is bad.

This fix updates the MAC address inside the
ncm_strings_defs global during the ncm_bind call.
This ensures each device has a unique MAC.
In f_ecm.c ecm_string_defs is updated in the same way.

The defunct MAC assignment in ncm_alloc has been removed.

Signed-off-by: raub camaioni <raubcameo@gmail.com>
Link: https://lore.kernel.org/r/20250815131358.1047525-1-raubcameo@gmail.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/usb/gadget/function/f_ncm.c