]> git.ipfire.org Git - thirdparty/kernel/stable.git/commit
xhci: use pm_ptr() instead of #ifdef for CONFIG_PM conditionals
authorArnd Bergmann <arnd@arndb.de>
Tue, 28 Mar 2023 13:10:43 +0000 (15:10 +0200)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Fri, 17 Jan 2025 12:34:49 +0000 (13:34 +0100)
commit9734fd7a27772016b1f6e31a03258338a219d7d6
treed159f744f67cd5a06c24209b541d2728e6409541
parentd208571943ffddc438a7ce533d5d0b9219806242
xhci: use pm_ptr() instead of #ifdef for CONFIG_PM conditionals

commit 130eac4170859fb368681e00d390f20f44bbf27b upstream.

A recent patch caused an unused-function warning in builds with
CONFIG_PM disabled, after the function became marked 'static':

drivers/usb/host/xhci-pci.c:91:13: error: 'xhci_msix_sync_irqs' defined but not used [-Werror=unused-function]
   91 | static void xhci_msix_sync_irqs(struct xhci_hcd *xhci)
      |             ^~~~~~~~~~~~~~~~~~~

This could be solved by adding another #ifdef, but as there is
a trend towards removing CONFIG_PM checks in favor of helper
macros, do the same conversion here and use pm_ptr() to get
either a function pointer or NULL but avoid the warning.

As the hidden functions reference some other symbols, make
sure those are visible at compile time, at the minimal cost of
a few extra bytes for 'struct usb_device'.

Fixes: 9abe15d55dcc ("xhci: Move xhci MSI sync function to to xhci-pci")
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Link: https://lore.kernel.org/r/20230328131114.1296430-1-arnd@kernel.org
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/usb/host/xhci-pci.c
include/linux/usb.h
include/linux/usb/hcd.h