]> git.ipfire.org Git - thirdparty/openvpn.git/commit
Really fix '--cipher none' regression
authorSteffan Karger <steffan@karger.me>
Tue, 2 Dec 2014 20:42:00 +0000 (21:42 +0100)
committerGert Doering <gert@greenie.muc.de>
Tue, 2 Dec 2014 21:10:56 +0000 (22:10 +0100)
commit98156e90e1e83133a6a6a020db8e7333ada6156b
tree1d71fea2e29e982a34b4135a995f405d6bde9ea2
parent6ece60c6dc7a3cda58f4dfea4e6cd3016023234f
Really fix '--cipher none' regression

... by not incorrectly hinting to the compiler the function argument of
cipher_kt_mode_{cbc,ofb_cfb}() is nonnull, since that no longer is the
case.

Verified the fix on Debian Wheezy, one of the platforms the reporter in
trac #473 mentions with a compiler that would optimize out the required
checks.

Also add a testcase for --cipher none to t_lpback, to prevent further
regressions.

Signed-off-by: Steffan Karger <steffan@karger.me>
Acked-by: Gert Doering <gert@greenie.muc.de>
Message-Id: <1417552920-31770-1-git-send-email-steffan@karger.me>
URL: http://article.gmane.org/gmane.network.openvpn.devel/9300
Signed-off-by: Gert Doering <gert@greenie.muc.de>
src/openvpn/crypto_backend.h
tests/t_lpback.sh