]> git.ipfire.org Git - thirdparty/sqlalchemy/sqlalchemy.git/commit
Support pool.connect() event firing before all else
authorMike Bayer <mike_mp@zzzcomputing.com>
Tue, 17 Nov 2020 22:13:24 +0000 (17:13 -0500)
committerMike Bayer <mike_mp@zzzcomputing.com>
Thu, 19 Nov 2020 18:40:54 +0000 (13:40 -0500)
commit9b779611f9bafd6c0affafda9732cecdb8efa761
tree41e98e407c5ca7872d3a97ce62214047c9c39bcf
parent7082e4c447c664af43a6576f5749c97a9951d7dd
Support pool.connect() event firing before all else

Fixed regression where a connection pool event specified with a keyword,
most notably ``insert=True``, would be lost when the event were set up.
This would prevent startup events that need to fire before dialect-level
events from working correctly.

The internal mechanics of the engine connection routine has been altered
such that it's now guaranteed that a user-defined event handler for the
:meth:`_pool.PoolEvents.connect` handler, when established using
``insert=True``, will allow an event handler to run that is definitely
invoked **before** any dialect-specific initialization starts up, most
notably when it does things like detect default schema name.
Previously, this would occur in most cases but not unconditionally.
A new example is added to the schema documentation illustrating how to
establish the "default schema name" within an on-connect event
(upcoming as part of I882edd5bbe06ee5b4d0a9c148854a57b2bcd4741)

Addiional changes to support setting default schema name:

The Oracle dialect now uses
``select sys_context( 'userenv', 'current_schema' ) from dual`` to get
the default schema name, rather than ``SELECT USER FROM DUAL``, to
accommodate for changes to the session-local schema name under Oracle.

Added a read/write ``.autocommit`` attribute to the DBAPI-adaptation layer
for the asyncpg dialect.   This so that when working with DBAPI-specific
schemes that need to use "autocommit" directly with the DBAPI connection,
the same ``.autocommit`` attribute which works with both psycopg2 as well
as pg8000 is available.

Fixes: #5716
Fixes: #5708
Change-Id: I7dce56b4345ffc720e25e2aaccb7e42bb29e5671
18 files changed:
doc/build/changelog/unreleased_14/5708.rst [new file with mode: 0644]
doc/build/changelog/unreleased_14/5716.rst [new file with mode: 0644]
lib/sqlalchemy/dialects/oracle/base.py
lib/sqlalchemy/dialects/oracle/provision.py
lib/sqlalchemy/dialects/postgresql/asyncpg.py
lib/sqlalchemy/dialects/postgresql/provision.py
lib/sqlalchemy/engine/create.py
lib/sqlalchemy/pool/events.py
lib/sqlalchemy/testing/provision.py
lib/sqlalchemy/testing/requirements.py
lib/sqlalchemy/testing/suite/test_dialect.py
lib/sqlalchemy/util/__init__.py
lib/sqlalchemy/util/compat.py
test/dialect/oracle/test_dialect.py
test/dialect/postgresql/test_dialect.py
test/engine/test_execute.py
test/engine/test_pool.py
test/requirements.py