]> git.ipfire.org Git - thirdparty/asterisk.git/commit
taskprocessor: Fix race condition between unreferencing and finding. 63/1163/1
authorJoshua Colp <jcolp@digium.com>
Sat, 29 Aug 2015 15:36:35 +0000 (12:36 -0300)
committerJoshua Colp <jcolp@digium.com>
Sat, 29 Aug 2015 15:36:35 +0000 (12:36 -0300)
commita676ba2aad5525926ae31b8317b95ae52cbbabbb
tree1760ef04c9aa07947bd9bb94d3a1fb15be703533
parent85e1cb51b21c2d194647e16b81b5a1344d2ff911
taskprocessor: Fix race condition between unreferencing and finding.

When unreferencing a taskprocessor its reference count is checked
to determine if it should be unlinked from the taskprocessors
container and its listener shut down. In between the time when the
reference count is checked and unlinking it is possible for
another thread to jump in, find it, and get a reference to it. If
the thread then uses the taskprocessor it may find that it is not
in the state it expects.

This change locks the taskprocessors container during almost the
entire unreference operation to ensure that any other thread which
may attempt to find the taskprocessor has to wait.

ASTERISK-25295

Change-Id: Icb842db82fe1cf238da55df92e95938a4419377c
main/taskprocessor.c