]> git.ipfire.org Git - thirdparty/postgresql.git/commit
Fix stale comment in parallel_vacuum_main().
authorMasahiko Sawada <msawada@postgresql.org>
Wed, 29 Jul 2026 16:52:07 +0000 (09:52 -0700)
committerMasahiko Sawada <msawada@postgresql.org>
Wed, 29 Jul 2026 16:52:07 +0000 (09:52 -0700)
commita84eca6627fe02d1e299b9a80dc4cb82a0b557ff
treec427b49e6d0eb53e9a95f53e419cc5082be9eb85
parent23a6e25593729feaafb6f3491a1222247f6e0125
Fix stale comment in parallel_vacuum_main().

The comment claimed that a parallel vacuum worker has only the
PROC_IN_VACUUM flag because parallel vacuum is not supported for
autovacuum, but commit 1ff3180ca01 allowed autovacuum to use parallel
vacuum workers.

The assertion itself still holds: the leader, whether a backend
running VACUUM or an autovacuum worker, sets PROC_IN_VACUUM before
taking its snapshot, and a parallel worker inherits the flag when
importing the leader's snapshot. The leader's other flags don't reach
the worker, since the snapshot import copies only the PROC_XMIN_FLAGS
bits and PROC_IS_AUTOVACUUM is never set on parallel workers, which
run as regular background workers. Reword the comment to explain that.

Oversight in commit 1ff3180ca01.

Author: Bharath Rupireddy <bharath.rupireddyforpostgres@gmail.com>
Reviewed-by: Masahiko Sawada <sawada.mshk@gmail.com>
Reviewed-by: Chao Li <li.evan.chao@gmail.com>
Discussion: https://postgr.es/m/CALj2ACVwQ4WABqq8Lnf+VZEJ45jcTFhyFLFr_ctfS4=QLL-r5w@mail.gmail.com
Backpatch-through: 19
src/backend/commands/vacuumparallel.c