]> git.ipfire.org Git - thirdparty/libvirt.git/commit
save: generate idempotent inactive xml for running domain
authorEric Blake <eblake@redhat.com>
Fri, 22 Jul 2011 03:37:33 +0000 (21:37 -0600)
committerEric Blake <eblake@redhat.com>
Fri, 29 Jul 2011 22:09:08 +0000 (16:09 -0600)
commita8be259d0cca071c5735c70580c247e9b44b2ebd
tree7fbb24c3bb4dd5e8338d64effeb99c7ebec8386a
parentdd20328fbbc359d1773fdaa5d462222127b7348a
save: generate idempotent inactive xml for running domain

Originally noticed by comparing the xml generated by virDomainSave
with the xml produced by reparsing and redumping that xml, but I
also did an audit of every last use of VIR_DOMAIN_XML_INACTIVE in
domain_conf.c to ensure that no other discrepancies exist.

* src/conf/domain_conf.c (virDomainDeviceInfoIsSet): Add
parameter, and update all callers.  Make static.
(virDomainNetDefFormat): Skip generated ifname.
(virDomainDefFormatInternal): Skip default <seclabel>.
(virDomainChrSourceDefParseXML): Skip generated pty path, and add
parameter.  Update callers.
* src/conf/domain_conf.h (virDomainDeviceInfoIsSet): Delete.
* src/libvirt_private.syms (domain_conf.h): Update.
src/conf/domain_conf.c
src/conf/domain_conf.h
src/libvirt_private.syms