]> git.ipfire.org Git - thirdparty/openssl.git/commit
Configurations/10-main.conf: In the VC-common target, unquote $(CC)
authorRichard Levitte <levitte@openssl.org>
Mon, 25 Jul 2022 06:07:33 +0000 (08:07 +0200)
committerHugo Landau <hlandau@openssl.org>
Tue, 26 Jul 2022 11:33:28 +0000 (12:33 +0100)
commitc04b8819161de007cee831dd9e58dde52268da18
tree0d981a1138432a51d25d98a49e6ca83ada687944
parentea66c8d85a7104b9da9169e4130bd739215ea12d
Configurations/10-main.conf: In the VC-common target, unquote $(CC)

Some of the VC-common attributes have values that use `$(CC)`, wrapped with
quotes.  However, `Configurations/windows-makefile.tmpl` already quotes the
`CC` value, like this:

    CC="{- $config{CC} -}"

The interaction between that makefile variable and the attributes using
`$(CC)` wrapped with quotes is a command line with the quotes doubled.  For
example, the value of `$(CPP)` becomes `""cl""`.

Strangely enough, this appears to be tolerated, at least on some versions of
Windows.  However, this has been reported not to be the case.

This is fixed by removing the quotes in `Configurations/10-main.conf`,
making `Configurations/windows-makefile.tmpl` responsible for proper
quoting.

Fixes #18823

Reviewed-by: Hugo Landau <hlandau@openssl.org>
Reviewed-by: Matt Caswell <matt@openssl.org>
(Merged from https://github.com/openssl/openssl/pull/18861)
Configurations/10-main.conf