]> git.ipfire.org Git - thirdparty/libvirt.git/commit
Fix path used for USB device attach with LXC
authorDaniel P. Berrange <berrange@redhat.com>
Tue, 4 Feb 2014 16:43:18 +0000 (16:43 +0000)
committerDaniel P. Berrange <berrange@redhat.com>
Mon, 17 Feb 2014 15:11:06 +0000 (15:11 +0000)
commitc3648972222d4eb056e6e667c193ba56a7aa3557
tree5e0d8a66597a03108e5138c2f00f96ebc0f0bf9f
parent7a44af963ef75c487f874bc91613ad45e5b167e9
Fix path used for USB device attach with LXC

The LXC code missed the 'usb' component out of the path
/dev/bus/usb/$BUSNUM/$DEVNUM, so it failed to actually
setup cgroups for the device. This was in fact lucky
because the call to virLXCSetupHostUsbDeviceCgroup
was also mistakenly passing '&priv->cgroup' instead of
just 'priv->cgroup'. So once the path is fixed, libvirtd
would then crash trying to access the bogus virCgroupPtr
pointer. This would have been a security issue, were it
not for the bogus path preventing the pointer reference
being reached.

Signed-off-by: Daniel P. Berrange <berrange@redhat.com>
src/lxc/lxc_driver.c