]> git.ipfire.org Git - thirdparty/postgresql.git/commit
Convert ddlutils regression tests to TAP tests.
authorAndrew Dunstan <andrew@dunslane.net>
Wed, 29 Apr 2026 15:10:23 +0000 (11:10 -0400)
committerAndrew Dunstan <andrew@dunslane.net>
Wed, 29 Apr 2026 15:34:01 +0000 (11:34 -0400)
commitc529ee38b9eb26527da05b85dee087676dd8fe37
tree32df2bec45890ba72c17a5d3eaa634423a492e9f
parent748d871b7cb08302ef312b665bd64012f19fc16c
Convert ddlutils regression tests to TAP tests.

The regression tests for pg_get_role_ddl(), pg_get_database_ddl(),
and pg_get_tablespace_ddl() created databases and tablespaces, which
are heavyweight operations.  As noted by Andres Freund, this is
wasteful in the core regression suite which gets run repeatedly.

Convert the three test files (role_ddl.sql, database_ddl.sql,
tablespace_ddl.sql) into a single TAP test that runs once, covering
all the same functionality: basic DDL generation, pretty-printing,
option handling, error cases, permission checks, and edge cases like
quoted names and role memberships.

Discussion: https://postgr.es/m/5c67dc79-909a-4e17-8606-6686667da6c6@dunslane.net
src/test/modules/test_misc/meson.build
src/test/modules/test_misc/t/012_ddlutils.pl [new file with mode: 0644]
src/test/regress/expected/database_ddl.out [deleted file]
src/test/regress/expected/role_ddl.out [deleted file]
src/test/regress/expected/tablespace_ddl.out [deleted file]
src/test/regress/parallel_schedule
src/test/regress/sql/database_ddl.sql [deleted file]
src/test/regress/sql/role_ddl.sql [deleted file]
src/test/regress/sql/tablespace_ddl.sql [deleted file]