]> git.ipfire.org Git - thirdparty/openssl.git/commit
Don't free aliased pointers in ctx cmp_ctx tests
authorNeil Horman <nhorman@openssl.org>
Wed, 22 Nov 2023 17:16:54 +0000 (12:16 -0500)
committerNeil Horman <nhorman@openssl.org>
Fri, 1 Dec 2023 15:52:01 +0000 (10:52 -0500)
commitc8ca810da9c47d8cb6988fd14e1cb4e20b0877e8
treee5e6914efd846211dd46a122df0bf58c6cc311d4
parent7eae6ee0e503b0961d4f2e75baac981f2766b892
Don't free aliased pointers in ctx cmp_ctx tests

Coverity recorded issues 1551739 and 1551737, a potential double free in the
tests.  It occurs when the DUP operation fails in such a way val3_read is
returned as the same pointer as val2_read.  Ideally it should never
happen, but resetting val3_read to 0 should satisfy coverity that there
is no issue here

Reviewed-by: Tomas Mraz <tomas@openssl.org>
Reviewed-by: Todd Short <todd.short@me.com>
(Merged from https://github.com/openssl/openssl/pull/22800)
test/cmp_ctx_test.c