]> git.ipfire.org Git - thirdparty/haproxy.git/commit
BUG/MEDIUM: mux-quic: fix crash on STOP_SENDING received without SD
authorAmaury Denoyelle <adenoyelle@haproxy.com>
Fri, 10 May 2024 08:42:07 +0000 (10:42 +0200)
committerAmaury Denoyelle <adenoyelle@haproxy.com>
Fri, 10 May 2024 09:01:05 +0000 (11:01 +0200)
commitcc9827bb0999dbba1f8542d8dd05bc2c57ad1f1d
tree5d72d5081d690b382ab3c6c1711499a5b67ecf0a
parentfbbc2925d403dd558ea254d9f57e7e46d39f37aa
BUG/MEDIUM: mux-quic: fix crash on STOP_SENDING received without SD

Abort reason code received on STOP_SENDING is notified to upper layer
since the following commit :
  367ce1ebf3e4cead319a9f01581037c9f0280e77
  MINOR: mux-quic: Set tha SE abort reason when a STOP_SENDING frame is received

However, this causes a crash when a STOP_SENDING is received on a QCS
instance without any stream instantiated. Fix this by checking first if
qcs->sd is not NULL before setting abort code.

This bug can easily be reproduced by emitting a STOP_SENDING as first
frame of a stream.

This should fix github issue #2563.

This does not need to be backported.
src/mux_quic.c