]> git.ipfire.org Git - thirdparty/kernel/stable.git/commit
drm/sched: Fix race in drm_sched_entity_select_rq()
authorPhilipp Stanner <phasta@kernel.org>
Wed, 22 Oct 2025 06:34:03 +0000 (08:34 +0200)
committerPhilipp Stanner <phasta@kernel.org>
Mon, 27 Oct 2025 12:48:46 +0000 (13:48 +0100)
commitd25e3a610bae03bffc5c14b5d944a5d0cd844678
tree5bd7a7e724e328faed6cb5a091b78d24be38b7b0
parent14e02ed3876f4ab0ed6d3f41972175f8b8df3d70
drm/sched: Fix race in drm_sched_entity_select_rq()

In a past bug fix it was forgotten that entity access must be protected
by the entity lock. That's a data race and potentially UB.

Move the spin_unlock() to the appropriate position.

Cc: stable@vger.kernel.org # v5.13+
Fixes: ac4eb83ab255 ("drm/sched: select new rq even if there is only one v3")
Reviewed-by: Tvrtko Ursulin <tvrtko.ursulin@igalia.com>
Signed-off-by: Philipp Stanner <phasta@kernel.org>
Link: https://patch.msgid.link/20251022063402.87318-2-phasta@kernel.org
drivers/gpu/drm/scheduler/sched_entity.c