]> git.ipfire.org Git - thirdparty/kernel/linux.git/commit
locking/mutex: Mark devm_mutex_init() as __must_check
authorThomas Weißschuh <linux@weissschuh.net>
Tue, 17 Jun 2025 17:08:14 +0000 (19:08 +0200)
committerBoqun Feng <boqun.feng@gmail.com>
Fri, 11 Jul 2025 22:11:54 +0000 (15:11 -0700)
commitdaec29dcc8731b7596690ab9f647839e4584a86d
tree1af9d7f03fe3024ad096621ecaa5d545c6f16835
parent3b07bb900af7f43f13f9ff398b4c6ca1dee217cd
locking/mutex: Mark devm_mutex_init() as __must_check

devm_mutex_init() can fail. With CONFIG_DEBUG_MUTEXES=y the mutex will be
marked as unusable and trigger errors on usage.
Enforce all callers check the return value through the compiler.

As devm_mutex_init() itself is a macro, it can not be annotated
directly. Annotate __devm_mutex_init() instead.
Unfortunately __must_check/warn_unused_result don't propagate through
statement expression. So move the statement expression into the argument
list of the call to __devm_mutex_init() through a helper macro.

Suggested-by: Peter Zijlstra <peterz@infradead.org>
Signed-off-by: Thomas Weißschuh <linux@weissschuh.net>
Reviewed-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Reviewed-by: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>
Signed-off-by: Boqun Feng <boqun.feng@gmail.com>
Link: https://lore.kernel.org/r/20250617-must_check-devm_mutex_init-v7-3-d9e449f4d224@weissschuh.net
include/linux/mutex.h