]> git.ipfire.org Git - thirdparty/binutils-gdb.git/commit
gdb/python: check return value of PyObject_New in all cases
authorAndrew Burgess <aburgess@redhat.com>
Wed, 20 Aug 2025 09:45:09 +0000 (10:45 +0100)
committerAndrew Burgess <aburgess@redhat.com>
Thu, 21 Aug 2025 10:47:17 +0000 (11:47 +0100)
commitdbd05b9edcf760a7001985f89bc760358a3c19d7
tree58b47b9fb55f36eed931c768dbd17e48f53e8d9d
parent8186f0d31ddf339ba6803cde97ef6a6310ca2587
gdb/python: check return value of PyObject_New in all cases

I spotted a few cases where the return value of PyObject_New was not
being checked against nullptr, but we were dereferencing the result.

All fixed here.  The fixed functions can now return NULL, so I checked
all the callers, and I believe there will handle a return of NULL
correctly.

Assuming calls to PyObject_New never fail, there should be no user
visible changes after this commit.

No tests here as I don't know how we'd go about causing a Python
object allocation to fail.

Approved-By: Simon Marchi <simon.marchi@efficios.com>
gdb/python/py-block.c
gdb/python/py-record.c
gdb/python/py-unwind.c