]> git.ipfire.org Git - thirdparty/kernel/stable.git/commit
x86/pvh: Call C code via the kernel virtual mapping
authorArd Biesheuvel <ardb@kernel.org>
Wed, 9 Oct 2024 16:04:40 +0000 (18:04 +0200)
committerJuergen Gross <jgross@suse.com>
Tue, 29 Oct 2024 16:23:28 +0000 (17:23 +0100)
commite8fbc0d9cab6c1ee6403f42c0991b0c1d5dbc092
tree73a70e52d88a1aa2153e32e5199c305a99b6c56d
parent81983758430957d9a5cb3333fe324fd70cf63e7e
x86/pvh: Call C code via the kernel virtual mapping

Calling C code via a different mapping than it was linked at is
problematic, because the compiler assumes that RIP-relative and absolute
symbol references are interchangeable. GCC in particular may use
RIP-relative per-CPU variable references even when not using -fpic.

So call xen_prepare_pvh() via its kernel virtual mapping on x86_64, so
that those RIP-relative references produce the correct values. This
matches the pre-existing behavior for i386, which also invokes
xen_prepare_pvh() via the kernel virtual mapping before invoking
startup_32 with paging disabled again.

Fixes: 7243b93345f7 ("xen/pvh: Bootstrap PVH guest")
Tested-by: Jason Andryuk <jason.andryuk@amd.com>
Reviewed-by: Jason Andryuk <jason.andryuk@amd.com>
Signed-off-by: Ard Biesheuvel <ardb@kernel.org>
Message-ID: <20241009160438.3884381-8-ardb+git@google.com>
Signed-off-by: Juergen Gross <jgross@suse.com>
arch/x86/platform/pvh/head.S