]> git.ipfire.org Git - thirdparty/krb5.git/commit
Fix minor utf8-to-ucs2s read overrun bug
authorGreg Hudson <ghudson@mit.edu>
Fri, 25 Sep 2015 21:31:53 +0000 (17:31 -0400)
committerGreg Hudson <ghudson@mit.edu>
Tue, 29 Sep 2015 18:19:19 +0000 (14:19 -0400)
commiteb52da21d72faa3d00b1205a5a0fdbabc45c9e6d
treefee0aa2254f585f1db51021de8166a054ecd42b0
parentfd0b693f00f4d0b7b603bf4a2b8812869ad1df19
Fix minor utf8-to-ucs2s read overrun bug

k5_utf8s_to_ucs2s() reads and ignores one extra byte from the input
string before terminating its loop, possibly overrunning the input
buffer of its caller.  This overrun is typically without consequence,
but can show up in tools like asan or valgrind during RC4
string-to-key operations.  Fix the bug by swapping the order of the
loop conditions.

ticket: 8253 (new)
target_version: 1.14
tags: pullup
src/util/support/utf8_conv.c