]> git.ipfire.org Git - thirdparty/kernel/linux.git/commit
net: mana: guard TX wq object destroy with INVALID_MANA_HANDLE check
authorAditya Garg <gargaditya@linux.microsoft.com>
Mon, 8 Jun 2026 10:13:41 +0000 (03:13 -0700)
committerJakub Kicinski <kuba@kernel.org>
Sat, 13 Jun 2026 00:26:05 +0000 (17:26 -0700)
commitf8fd56977eeea3d6939b1a9cd8bd36f1779b3ad0
tree9233729f46d57e227cfa27e68dcc2d771e079e86
parent5985474e1cb4034680fac2145497a94b0860be50
net: mana: guard TX wq object destroy with INVALID_MANA_HANDLE check

mana_create_txq() has several error paths (after mana_alloc_queues() or
mana_create_wq_obj() failure) where tx_qp[i].tx_object stays as the
INVALID_MANA_HANDLE sentinel set at allocation. mana_destroy_txq() then
unconditionally calls mana_destroy_wq_obj() with (u64)-1, which firmware
rejects and logs an error.

Mirror the RX-side pattern in mana_destroy_rxq() and skip the destroy
when the handle is still INVALID_MANA_HANDLE.

Fixes: ca9c54d2d6a5 ("net: mana: Add a driver for Microsoft Azure Network Adapter (MANA)")
Signed-off-by: Aditya Garg <gargaditya@linux.microsoft.com>
Reviewed-by: Dipayaan Roy <dipayanroy@linux.microsoft.com>
Reviewed-by: Haiyang Zhang <haiyangz@microsoft.com>
Link: https://patch.msgid.link/20260608101345.2267320-3-gargaditya@linux.microsoft.com
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
drivers/net/ethernet/microsoft/mana/mana_en.c