]> git.ipfire.org Git - thirdparty/kernel/stable.git/commit
accel/qaic: Fix bootlog initialization ordering
authorJeffrey Hugo <quic_jhugo@quicinc.com>
Tue, 7 Oct 2025 11:57:50 +0000 (13:57 +0200)
committerJeff Hugo <jeff.hugo@oss.qualcomm.com>
Tue, 14 Oct 2025 14:30:39 +0000 (08:30 -0600)
commitfd6e385528d8f85993b7bfc6430576136bb14c65
treeb53c8cc41d976d68d58b47779be90af2b76eeea2
parent48a710760e10a4f36e11233a21860796ba204b1e
accel/qaic: Fix bootlog initialization ordering

As soon as we queue MHI buffers to receive the bootlog from the device,
we could be receiving data. Therefore all the resources needed to
process that data need to be setup prior to queuing the buffers.

We currently initialize some of the resources after queuing the buffers
which creates a race between the probe() and any data that comes back
from the device. If the uninitialized resources are accessed, we could
see page faults.

Fix the init ordering to close the race.

Fixes: 5f8df5c6def6 ("accel/qaic: Add bootlog debugfs")
Signed-off-by: Jeffrey Hugo <quic_jhugo@quicinc.com>
Signed-off-by: Youssef Samir <youssef.abdulrahman@oss.qualcomm.com>
Reviewed-by: Jeff Hugo <jeff.hugo@oss.qualcomm.com>
Reviewed-by: Carl Vanderlip <carl.vanderlip@oss.qualcomm.com>
Signed-off-by: Jeff Hugo <jeff.hugo@oss.qualcomm.com>
Link: https://lore.kernel.org/r/20251007115750.332169-1-youssef.abdulrahman@oss.qualcomm.com
drivers/accel/qaic/qaic_debugfs.c