]> git.ipfire.org Git - thirdparty/kernel/stable.git/commit
mailbox: pcc: don't zero error register
authorJamie Iles <jamie.iles@oss.qualcomm.com>
Wed, 5 Nov 2025 14:42:29 +0000 (14:42 +0000)
committerJassi Brar <jassisinghbrar@gmail.com>
Fri, 28 Nov 2025 15:31:53 +0000 (09:31 -0600)
commitff0e4d4c97c94af34cc9cad37b5a5cdbe597a3b0
treee11d8ce81d4ed1e58bc775401fe5642267200548
parent094b53ecaa3ef227f9c800f8de90a9b44f1c1bb4
mailbox: pcc: don't zero error register

The error status mask for a type 3/4 subspace is used for reading the
error status, and the bitwise inverse is used for clearing the error
with the intent being to preserve any of the non-error bits.  However,
we were previously applying the mask to extract the status and then
applying the inverse to the result which ended up clearing all bits.

Instead, store the inverse mask in the preserve mask and then use that
on the original value read from the error status so that only the error
is cleared.

Fixes: c45ded7e1135 ("mailbox: pcc: Add support for PCCT extended PCC subspaces(type 3/4)")
Signed-off-by: Jamie Iles <jamie.iles@oss.qualcomm.com>
Signed-off-by: Punit Agrawal <punit.agrawal@oss.qualcomm.com>
Signed-off-by: Jassi Brar <jassisinghbrar@gmail.com>
drivers/mailbox/pcc.c