]> git.ipfire.org Git - thirdparty/libvirt.git/commit
storage: Fix lvcreate parameter for backingStore.
authorAtsushi Kumagai <kumagai-atsushi@mxc.nes.nec.co.jp>
Fri, 18 Jan 2013 07:06:01 +0000 (08:06 +0100)
committerMichal Privoznik <mprivozn@redhat.com>
Fri, 18 Jan 2013 07:06:01 +0000 (08:06 +0100)
commitffee627a4a52bf13d787cec883054fe2e7d9465c
tree4ffe6838c188a7f394413647567bd2924ee954b5
parentf403bdc1891d5f7e20f268a592b2fa9fb1e2566f
storage: Fix lvcreate parameter for backingStore.

When virStorageBackendLogicalCreateVol() creates a snapshot for a
logical volume with backingStore element, it fails with the message
below:

  2013-01-17 03:10:18.869+0000: 1967: error : virCommandWait:2345 :
  internal error Child process (/sbin/lvcreate --name lvm-snapshot -L 51200K
  -s=/dev/lvm-pool/lvm-volume) unexpected exit status 3: /sbin/lvcreate:
  invalid option -- '='  Error during parsing of command line.

This is because virCommandAddArgPair() uses '=' to connect the two
parameters, it's unsuitable for -s option of the lvcreate.

Signed-off-by: Atsushi Kumagai <kumagai-atsushi@mxc.nes.nec.co.jp>
src/storage/storage_backend_logical.c