]> git.ipfire.org Git - thirdparty/gcc.git/commit
[PR107195] Set range to zero when nonzero mask is 0.
authorAldy Hernandez <aldyh@redhat.com>
Mon, 10 Oct 2022 18:42:10 +0000 (20:42 +0200)
committerAldy Hernandez <aldyh@redhat.com>
Tue, 11 Oct 2022 08:30:44 +0000 (10:30 +0200)
commitc4d15dddf6b9eacb36f535807ad2ee364af46e04
treec8471cd057a40f070c65d04241e71ce73510d69e
parent0ecd0f1cc6f8f3ba818946a42b22c2ab61f46825
[PR107195] Set range to zero when nonzero mask is 0.

When solving 0 = _15 & 1, we calculate _15 as:

[irange] int [-INF, -2][0, +INF] NONZERO 0xfffffffe

The known value of _15 is [0, 1] NONZERO 0x1 which is intersected with
the above, yielding:

[0, 1] NONZERO 0x0

This eventually gets copied to a _Bool [0, 1] NONZERO 0x0.

This is problematic because here we have a bool which is zero, but
returns false for irange::zero_p, since the latter does not look at
nonzero bits.  This causes logical_combine to assume the range is
not-zero, and all hell breaks loose.

I think we should just normalize a nonzero mask of 0 to [0, 0] at
creation, thus avoiding all this.

PR tree-optimization/107195

gcc/ChangeLog:

* value-range.cc (irange::set_range_from_nonzero_bits): Set range
to [0,0] when nonzero mask is 0.

gcc/testsuite/ChangeLog:

* gcc.dg/tree-ssa/pr107195-1.c: New test.
* gcc.dg/tree-ssa/pr107195-2.c: New test.
gcc/testsuite/gcc.dg/tree-ssa/pr107195-1.c [new file with mode: 0644]
gcc/testsuite/gcc.dg/tree-ssa/pr107195-2.c [new file with mode: 0644]
gcc/value-range.cc