]> git.ipfire.org Git - thirdparty/libvirt.git/commit
qemu: Pass qemuCaps to qemuMigrationCookieXMLParse
authorJiri Denemark <jdenemar@redhat.com>
Tue, 6 Aug 2019 10:31:45 +0000 (12:31 +0200)
committerJiri Denemark <jdenemar@redhat.com>
Fri, 9 Aug 2019 11:55:54 +0000 (13:55 +0200)
commitbf15b145ec473c0ca5bfe8aee2bf0eb1691b6f1c
treea8939a45639aece1189ea23a142ef95da10ef5a4
parent6e7c33dad7f2f90182c452917f3a555e2c878d42
qemu: Pass qemuCaps to qemuMigrationCookieXMLParse

Since qemuDomainDefPostParse callback requires qemuCaps, we need to make
sure it gets the capabilities stored in the domain's private data if the
domain is running. Passing NULL may cause QEMU capabilities probing to
be triggered in case QEMU binary changed in the meantime. When this
happens while a running domain object is locked, QMP event delivered to
the domain before QEMU capabilities probing finishes will deadlock the
event loop.

This patch fixes all paths leading to qemuMigrationCookieXMLParse.

Signed-off-by: Jiri Denemark <jdenemar@redhat.com>
Reviewed-by: Michal Privoznik <mprivozn@redhat.com>
src/qemu/qemu_migration_cookie.c