From 00240899ec0b0bb296ee54860802adec3be0d26e Mon Sep 17 00:00:00 2001 From: Stefano Brivio Date: Mon, 29 Oct 2018 23:04:25 +0100 Subject: [PATCH] ss: Actually print left delimiter for columns While rendering columns, we use a local variable to keep track of the field currently being printed, without touching current_field, which is used for buffering. Use the right pointer to access the left delimiter for the current column, instead of always printing the left delimiter for the last buffered field, which is usually an empty string. This fixes an issue especially visible on narrow terminals, where some columns might be displayed without separation. Reported-by: YoyPa Fixes: 691bd854bf4a ("ss: Buffer raw fields first, then render them as a table") Signed-off-by: Stefano Brivio Tested-by: YoyPa Signed-off-by: Stephen Hemminger --- misc/ss.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/misc/ss.c b/misc/ss.c index c8970438c..4d12fb5d1 100644 --- a/misc/ss.c +++ b/misc/ss.c @@ -1260,7 +1260,7 @@ static void render(void) while (token) { /* Print left delimiter only if we already started a line */ if (line_started++) - printed = printf("%s", current_field->ldelim); + printed = printf("%s", f->ldelim); else printed = 0; -- 2.47.2