From 0268a35db4e585f82668dfeacc2894302801178f Mon Sep 17 00:00:00 2001 From: John Ferlan Date: Fri, 12 Sep 2014 08:04:28 -0400 Subject: [PATCH] virsh: Resolve Coverity DEADCODE Coverity complains that on the first pass through the for loop that 'params' cannot be true, thus the ternary setting to "&" cannot be done. Since we can only ever get to this point once, drop the ternary --- tools/virsh-domain.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/tools/virsh-domain.c b/tools/virsh-domain.c index f80741caf0..31aa2e48a9 100644 --- a/tools/virsh-domain.c +++ b/tools/virsh-domain.c @@ -9825,8 +9825,7 @@ cmdDomDisplay(vshControl *ctl, const vshCmd *cmd) /* TLS Port */ if (tls_port) { virBufferAsprintf(&buf, - "%stls-port=%d", - params ? "&" : "?", + "?tls-port=%d", tls_port); params = true; } -- 2.47.2