From 027e6efd2b432232562d726f14702f79792b38cb Mon Sep 17 00:00:00 2001 From: Eric Sandeen Date: Mon, 30 May 2016 10:35:56 +1000 Subject: [PATCH] xfs_db: defang frag command Too many people freak out about this fictitious "fragmentation factor." As shown in the fact, it is largely meaningless, because the number approaches 100% extremely quickly for just a few extents per file. I thought about removing it altogether, but perhaps a note about its uselessness, and a more soothing metric (avg extents per file) might be useful. Signed-off-by: Eric Sandeen Reviewed-by: Christoph Hellwig Signed-off-by: Dave Chinner --- db/frag.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/db/frag.c b/db/frag.c index 36bb6895b..e11b140b2 100644 --- a/db/frag.c +++ b/db/frag.c @@ -172,6 +172,10 @@ frag_f( answer = 0.0; dbprintf(_("actual %llu, ideal %llu, fragmentation factor %.2f%%\n"), extcount_actual, extcount_ideal, answer); + dbprintf(_("Note, this number is largely meaningless.\n")); + answer = (double)extcount_actual / (double)extcount_ideal; + dbprintf(_("Files on this filesystem average %.2f extents per file\n"), + answer); return 0; } -- 2.47.2