From 02dd5cb79db015f715e2d64917db75cadde2bc64 Mon Sep 17 00:00:00 2001 From: Amos Jeffries Date: Mon, 6 Oct 2008 05:34:25 -0600 Subject: [PATCH] Coverity detected. inconsistent error detection on StoreIOBUffer Audit reveals only one of several callers which might set negative length state were checking for it and setting error flag properly. Makes more sense for the StoreIOBuffer constructor to do its own error state detection with information than to offload on callers. --- helpers/ntlm_auth/fakeauth/fakeauth_auth.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/helpers/ntlm_auth/fakeauth/fakeauth_auth.c b/helpers/ntlm_auth/fakeauth/fakeauth_auth.c index e30170a846..18c75fc3bd 100755 --- a/helpers/ntlm_auth/fakeauth/fakeauth_auth.c +++ b/helpers/ntlm_auth/fakeauth/fakeauth_auth.c @@ -428,7 +428,10 @@ main(int argc, char *argv[]) } else SEND2("TT %s", data); } else if (strncasecmp(buf, "KK ", 3) == 0) { - if (!ntlmCheckHeader((ntlmhdr *) decoded, NTLM_AUTHENTICATE)) { + if(!decoded) { + SEND2("BH received KK with no data! user=%s", user); + } + else if (!ntlmCheckHeader((ntlmhdr *) decoded, NTLM_AUTHENTICATE)) { if (!ntlmDecodeAuth((struct ntlm_authenticate *) decoded, user, 256)) { lc(user); if (strip_domain_enabled) { -- 2.47.2