From 0364ca33097da247ef6539c765405657324f243e Mon Sep 17 00:00:00 2001 From: Alok Tiwari Date: Mon, 20 Oct 2025 10:09:13 -0700 Subject: [PATCH] devlink: region: correct port region lookup to use port_ops The function devlink_port_region_get_by_name() incorrectly uses region->ops->name to compare the region name. as it is not any critical impact as ops and port_ops define as union for devlink_region but as per code logic it should refer port_ops here. No functional impact as ops and port_ops are part of same union, and name is the first member of both. Update it to use region->port_ops->name to properly reference the name of the devlink port region. Signed-off-by: Alok Tiwari Reviewed-by: Jiri Pirko Link: https://patch.msgid.link/20251020170916.1741808-1-alok.a.tiwari@oracle.com Signed-off-by: Jakub Kicinski --- net/devlink/region.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/net/devlink/region.c b/net/devlink/region.c index 63fb297f6d678..d6e5805cf3a09 100644 --- a/net/devlink/region.c +++ b/net/devlink/region.c @@ -50,7 +50,7 @@ devlink_port_region_get_by_name(struct devlink_port *port, struct devlink_region *region; list_for_each_entry(region, &port->region_list, list) - if (!strcmp(region->ops->name, region_name)) + if (!strcmp(region->port_ops->name, region_name)) return region; return NULL; -- 2.47.3