From 03b75822d13c07ae619b32901636ce00a0c9368e Mon Sep 17 00:00:00 2001 From: "Stephanie J. Lockwood-Childs" Date: Fri, 16 Aug 2013 15:03:41 -0400 Subject: [PATCH] gentoo: support running tests under sandbox when glibc runs its tests, it does so by invoking the local library loader. in Gentoo, we build/run inside of our "sandbox" which itself is linked against libdl (so that it can load libraries and pull out symbols). the trouble is that when you upgrade from an older glibc to the new one, often times internal symbols change name or abi. this is normally OK as you cannot use libc.so from say version 2.3.6 but libpthread.so from say version 2.5, so we always say "keep all of the glibc libraries from the same build". but when glibc runs its tests, it uses dynamic paths to point to its new local copies of libraries. if the test doesnt use libdl, then glibc doesnt add its path, and when sandbox triggers the loading of libdl, glibc does so from the host system system. this gets us into the case of all libraries are from the locally compiled version of glibc except for libdl.so. http://bugs.gentoo.org/56898 --- Makeconfig | 2 +- iconvdata/run-iconv-test.sh | 2 +- nptl/tst-tls6.sh | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/Makeconfig b/Makeconfig index cef0f06b640..d01ee2d90df 100644 --- a/Makeconfig +++ b/Makeconfig @@ -616,7 +616,7 @@ comma = , sysdep-library-path = \ $(subst $(empty) ,:,$(strip $(patsubst -Wl$(comma)-rpath-link=%, %,\ $(filter -Wl$(comma)-rpath-link=%,\ - $(sysdep-LDFLAGS))))) + $(sysdep-LDFLAGS)))) $(common-objpfx)/dlfcn) # $(run-via-rtld-prefix) is a command that, when prepended to the name # of a program built with the newly built library, produces a command # that, executed on the host for which the library is built, runs that diff --git a/iconvdata/run-iconv-test.sh b/iconvdata/run-iconv-test.sh index 5dfb69fe3a7..669c2e40dad 100755 --- a/iconvdata/run-iconv-test.sh +++ b/iconvdata/run-iconv-test.sh @@ -31,7 +31,7 @@ temp2=$codir/iconvdata/iconv-test.yyy trap "rm -f $temp1 $temp2" 1 2 3 15 # We have to have some directories in the library path. -LIBPATH=$codir:$codir/iconvdata +LIBPATH=$codir:$codir/iconvdata:$codir/dlfcn # How the start the iconv(1) program. ICONV='$codir/elf/ld.so --library-path $LIBPATH --inhibit-rpath ${from}.so \ diff --git a/nptl/tst-tls6.sh b/nptl/tst-tls6.sh index 846c3219e5b..dae92783eaf 100755 --- a/nptl/tst-tls6.sh +++ b/nptl/tst-tls6.sh @@ -26,7 +26,7 @@ run_program_env=$1; shift logfile=$common_objpfx/nptl/tst-tls6.out # We have to find libc and nptl -library_path=${common_objpfx}:${common_objpfx}nptl +library_path=${common_objpfx}:${common_objpfx}nptl:${common_objpfx}/dlfcn tst_tls5="${test_via_rtld_prefix} ${common_objpfx}/nptl/tst-tls5" > $logfile -- 2.47.2