From 03ef9eec78c4a718ead2bbfa82950f1024247ddf Mon Sep 17 00:00:00 2001 From: amosjeffries <> Date: Wed, 27 Feb 2008 17:41:16 +0000 Subject: [PATCH] Author: Christos Tsantilas Bug 2172: When user fails authentification Squid restarts Replaced an assertion that there is no auth_user_request, a comment what to do when there is no auth_user_request, and a comment that there can be no auth_user_request with what the first comment suggested to do. --- src/ACLChecklist.cc | 11 ++++------- 1 file changed, 4 insertions(+), 7 deletions(-) diff --git a/src/ACLChecklist.cc b/src/ACLChecklist.cc index f5d0181949..a59170069b 100644 --- a/src/ACLChecklist.cc +++ b/src/ACLChecklist.cc @@ -1,5 +1,5 @@ /* - * $Id: ACLChecklist.cc,v 1.42 2007/09/01 05:56:37 amosjeffries Exp $ + * $Id: ACLChecklist.cc,v 1.42.2.1 2008/02/27 10:41:16 amosjeffries Exp $ * * DEBUG: section 28 Access Control * AUTHOR: Duane Wessels @@ -394,12 +394,9 @@ ACLChecklist::~ACLChecklist() HTTPMSGUNLOCK(reply); - /* - * DPW 2007-05-08 - * If this fails, then we'll need a backup UNLOCK call in the - * destructor. - */ - assert(auth_user_request == NULL); + // no auth_user_request in builds without any Authentication configured + if (auth_user_request) + AUTHUSERREQUESTUNLOCK(auth_user_request, "ACLChecklist destructor"); conn_ = NULL; -- 2.47.2