From 041f6c19a0cd40fe684571c380399be518b8d6b2 Mon Sep 17 00:00:00 2001 From: Carl Love Date: Fri, 3 Sep 2021 16:36:31 +0000 Subject: [PATCH] Remove a unneeded / unnecessary prefix check. The pstxvp instruction is valid for R=1, i.e. use pc relative addressing. The test should have been remmoved before committing the ISA 3.1 support. https://bugs.kde.org/show_bug.cgi?id=441512 --- NEWS | 1 + VEX/priv/guest_ppc_toIR.c | 6 ------ 2 files changed, 1 insertion(+), 6 deletions(-) diff --git a/NEWS b/NEWS index 66a4b8d8bc..5643be5e47 100644 --- a/NEWS +++ b/NEWS @@ -52,6 +52,7 @@ are not entered into bugzilla tend to get forgotten about or ignored. 439590 glibc-2.34 breaks suppressions against obj:*/lib*/libc-2.*so* 440670 unhandled ppc64le-linux syscall: 252 (statfs64) and 253 (fstatfs64) 432387 s390x: z15 instructions support +441512 Remove a unneeded / unnecessary prefix check. To see details of a given bug, visit https://bugs.kde.org/show_bug.cgi?id=XXXXXX diff --git a/VEX/priv/guest_ppc_toIR.c b/VEX/priv/guest_ppc_toIR.c index f223fe9456..57ac7bcf48 100644 --- a/VEX/priv/guest_ppc_toIR.c +++ b/VEX/priv/guest_ppc_toIR.c @@ -14563,12 +14563,6 @@ static Bool dis_fp_pair_prefix ( UInt prefix, UInt theInstr ) pDIP( is_prefix, "stxvp %u,%llu(%u)\n", XTp, immediate_val, rA_addr ); DIPp( is_prefix, ",%u", R ); - if ( R == 1 ) { - vex_printf("Illegal instruction R = 1; pstxvp %u,%llu(%u)\n", - XTp, immediate_val, rA_addr ); - return False; - } - assign( EA_8, binop( Iop_Add64, mkU64( 8 ), mkexpr( EA ) ) ); assign( EA_16, binop( Iop_Add64, mkU64( 16 ), mkexpr( EA ) ) ); assign( EA_24, binop( Iop_Add64, mkU64( 24 ), mkexpr( EA ) ) ); -- 2.47.2