From 049df8751aeef2ccbae6d6aa9bd51a7e1a35b13a Mon Sep 17 00:00:00 2001 From: "Alan T. DeKok" Date: Wed, 13 Nov 2024 16:17:32 -0500 Subject: [PATCH] check return code --- src/lib/util/dict_unknown.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/src/lib/util/dict_unknown.c b/src/lib/util/dict_unknown.c index 46ff383f0aa..b4033caa25c 100644 --- a/src/lib/util/dict_unknown.c +++ b/src/lib/util/dict_unknown.c @@ -201,6 +201,7 @@ static fr_dict_attr_t *dict_unknown_alloc(TALLOC_CTX *ctx, fr_dict_attr_t const if (da->parent && da->parent->flags.is_unknown) { parent = fr_dict_attr_unknown_copy(n, da->parent); if (!parent) { + error: talloc_free(n); return NULL; } @@ -212,7 +213,9 @@ static fr_dict_attr_t *dict_unknown_alloc(TALLOC_CTX *ctx, fr_dict_attr_t const /* * Initialize the rest of the fields. */ - dict_attr_init(&n, parent, da->name, da->attr, type, &(dict_attr_args_t){ .flags = &flags }); + if (dict_attr_init(&n, parent, da->name, da->attr, type, &(dict_attr_args_t){ .flags = &flags }) < 0) { + goto error; + } if (type != FR_TYPE_OCTETS) dict_attr_ext_copy_all(&n, da); DA_VERIFY(n); -- 2.47.3