From 04dd9cdbe59a9056b4cc8de07e1585db77661cbc Mon Sep 17 00:00:00 2001 From: Chuck Lever Date: Mon, 1 Jun 2026 13:54:12 -0400 Subject: [PATCH] xprtrdma: Fix I3 invariant comment in rpcrdma_complete_rqst frwr_unmap_sync() and frwr_unmap_async() drain rl_registered via rpcrdma_mr_pop() before posting invalidation Work Requests to hardware. The WARN_ON_ONCE verifies that the list-drain step has occurred, not that hardware unmapping has completed. Reword the comment to match what the assertion actually checks. Signed-off-by: Chuck Lever Signed-off-by: Anna Schumaker --- net/sunrpc/xprtrdma/rpc_rdma.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/net/sunrpc/xprtrdma/rpc_rdma.c b/net/sunrpc/xprtrdma/rpc_rdma.c index 626cadec4555d..f115baba6d563 100644 --- a/net/sunrpc/xprtrdma/rpc_rdma.c +++ b/net/sunrpc/xprtrdma/rpc_rdma.c @@ -1336,8 +1336,8 @@ void rpcrdma_complete_rqst(struct rpcrdma_rep *rep) struct rpc_rqst *rqst = rep->rr_rqst; int status; - /* I3: every registered MR has been invalidated and - * ib_dma_unmap_sg()'d before complete_rqst runs. + /* I3: rl_registered has been drained by frwr_unmap before + * complete_rqst runs. */ WARN_ON_ONCE(!list_empty(&rpcr_to_rdmar(rqst)->rl_registered)); -- 2.47.3