From 051d228b1cba2de97d4e2eec23342bc773623876 Mon Sep 17 00:00:00 2001 From: Daan De Meyer Date: Fri, 13 Feb 2026 11:15:05 +0100 Subject: [PATCH] tree-wide: Add some extra debug logging --- src/basic/terminal-util.c | 3 ++- src/machine/machine-dbus.c | 5 ++++- 2 files changed, 6 insertions(+), 2 deletions(-) diff --git a/src/basic/terminal-util.c b/src/basic/terminal-util.c index 1013e38d0db..732ab0824d4 100644 --- a/src/basic/terminal-util.c +++ b/src/basic/terminal-util.c @@ -31,6 +31,7 @@ #include "namespace-util.h" #include "parse-util.h" #include "path-util.h" +#include "pidref.h" #include "proc-cmdline.h" #include "process-util.h" #include "signal-util.h" @@ -1666,7 +1667,7 @@ int openpt_allocate_in_namespace( r = pidref_namespace_open(pidref, &pidnsfd, &mntnsfd, /* ret_netns_fd= */ NULL, &usernsfd, &rootfd); if (r < 0) - return r; + return log_debug_errno(r, "Failed to open namespaces of PID "PID_FMT": %m", pidref->pid); if (socketpair(AF_UNIX, SOCK_DGRAM|SOCK_CLOEXEC, 0, pair) < 0) return -errno; diff --git a/src/machine/machine-dbus.c b/src/machine/machine-dbus.c index 6bee74fd300..e3281e1d385 100644 --- a/src/machine/machine-dbus.c +++ b/src/machine/machine-dbus.c @@ -376,7 +376,10 @@ int bus_machine_method_open_shell(sd_bus_message *message, void *userdata, sd_bu if (m->uid != 0 && m->class != MACHINE_HOST) { r = pidref_in_same_namespace(&PIDREF_MAKE_FROM_PID(1), &m->leader, NAMESPACE_USER); if (r < 0) - return r; + return log_debug_errno( + r, + "Failed to check if machine '%s' is running in the root user namespace: %m", + m->name); if (r != 0) return sd_bus_error_set( error, -- 2.47.3