From 0596ae31af50902f483f32196c7eaa934b2eb496 Mon Sep 17 00:00:00 2001 From: Leonardo Sandoval Date: Mon, 4 Sep 2017 14:35:47 -0700 Subject: [PATCH] package_deb, ipk: improve subprocess output on package manager command Redirecting stderr to stdout helps debugging issues, i.e instead of just getting the return code, get also the error log from the pkg manger This commit is in the way to figure out the root cause of [YOCTO #12012], where dpkg-deb fails with a 2 return code and according to the man page, there are multiple issues leading to the same code. Signed-off-by: Leonardo Sandoval Signed-off-by: Ross Burton (cherry picked from commit 9ff023fb26f5f0ce19e757beda00ccc32c009b21) Signed-off-by: Andreas Oberritter --- meta/classes/package_deb.bbclass | 4 +++- meta/classes/package_ipk.bbclass | 4 +++- 2 files changed, 6 insertions(+), 2 deletions(-) diff --git a/meta/classes/package_deb.bbclass b/meta/classes/package_deb.bbclass index 69363db7f44..eb08572d859 100644 --- a/meta/classes/package_deb.bbclass +++ b/meta/classes/package_deb.bbclass @@ -305,7 +305,9 @@ python do_package_deb () { conffiles.close() os.chdir(basedir) - subprocess.check_output("PATH=\"%s\" dpkg-deb --uniform-compression -b %s %s" % (localdata.getVar("PATH"), root, pkgoutdir), shell=True) + subprocess.check_output("PATH=\"%s\" dpkg-deb --uniform-compression -b %s %s" % (localdata.getVar("PATH"), root, pkgoutdir), + stderr=subprocess.STDOUT, + shell=True) cleanupcontrol(root) bb.utils.unlockfile(lf) diff --git a/meta/classes/package_ipk.bbclass b/meta/classes/package_ipk.bbclass index 7d3a6a4e9e8..4d2db94c9cd 100644 --- a/meta/classes/package_ipk.bbclass +++ b/meta/classes/package_ipk.bbclass @@ -232,7 +232,9 @@ python do_package_ipk () { os.chdir(basedir) subprocess.check_output("PATH=\"%s\" %s %s %s" % (localdata.getVar("PATH"), - d.getVar("OPKGBUILDCMD"), pkg, pkgoutdir), shell=True) + d.getVar("OPKGBUILDCMD"), pkg, pkgoutdir), + stderr=subprocess.STDOUT, + shell=True) if d.getVar('IPK_SIGN_PACKAGES') == '1': ipkver = "%s-%s" % (d.getVar('PKGV'), d.getVar('PKGR')) -- 2.47.2