From 062c46b69198fc979fdc41bfabf63bb13c6f1871 Mon Sep 17 00:00:00 2001 From: Mike Bayer Date: Sat, 13 Jun 2009 19:29:19 +0000 Subject: [PATCH] enabled missing reflection tests --- lib/sqlalchemy/dialects/sqlite/base.py | 2 +- lib/sqlalchemy/schema.py | 4 ---- test/engine/test_reflection.py | 4 ++-- 3 files changed, 3 insertions(+), 7 deletions(-) diff --git a/lib/sqlalchemy/dialects/sqlite/base.py b/lib/sqlalchemy/dialects/sqlite/base.py index c6228ca2f3..83c405f69f 100644 --- a/lib/sqlalchemy/dialects/sqlite/base.py +++ b/lib/sqlalchemy/dialects/sqlite/base.py @@ -501,7 +501,7 @@ class SQLiteDialect(default.DefaultDialect): indexes.append(dict(name=row[1], column_names=[], unique=row[2])) # loop thru unique indexes to get the column names. for idx in indexes: - c = connection.execute("%sindex_info(%s)" % (pragma, idx['name'])) + c = connection.execute("%sindex_info(%s)" % (pragma, quote(idx['name']))) cols = idx['column_names'] while True: row = c.fetchone() diff --git a/lib/sqlalchemy/schema.py b/lib/sqlalchemy/schema.py index d2ac36e4bd..2cd712476e 100644 --- a/lib/sqlalchemy/schema.py +++ b/lib/sqlalchemy/schema.py @@ -559,10 +559,6 @@ class Column(SchemaItem, expression.ColumnClause): if args: coltype = args[0] - # adjust for partials - if util.callable(coltype): - coltype = args[0]() - if (isinstance(coltype, types.AbstractType) or (isinstance(coltype, type) and issubclass(coltype, types.AbstractType))): diff --git a/test/engine/test_reflection.py b/test/engine/test_reflection.py index 758c9313be..33f7190121 100644 --- a/test/engine/test_reflection.py +++ b/test/engine/test_reflection.py @@ -571,7 +571,7 @@ class ReflectionTest(TestBase, ComparesTables): m9.reflect() self.assert_(not m9.tables) - @testing.fails_on_everything_except('postgres', 'mysql') + @testing.fails_on_everything_except('postgres', 'mysql', 'sqlite') def test_index_reflection(self): m1 = MetaData(testing.db) t1 = Table('party', m1, @@ -878,7 +878,7 @@ def dropViews(con, schema=None): con.execute(sa.sql.text(query)) -class ReflectionTest(TestBase): +class ComponentReflectionTest(TestBase): @testing.fails_on('sqlite', 'no schemas') def test_get_schema_names(self): -- 2.47.3