From 07697d7ec501ccca25281b30c26b4b2dcbc357e7 Mon Sep 17 00:00:00 2001 From: Lennart Poettering Date: Mon, 2 Oct 2017 12:57:03 +0200 Subject: [PATCH] service: add explanatory comments to control_pid_good() and cgroup_good() Let's add a similar comment to each as we already have for main_pid_good(), emphasizing that these functions are supposed to be have very similar. --- src/core/service.c | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/src/core/service.c b/src/core/service.c index b6f929051e2..56e07de69e0 100644 --- a/src/core/service.c +++ b/src/core/service.c @@ -1425,6 +1425,10 @@ static int main_pid_good(Service *s) { _pure_ static int control_pid_good(Service *s) { assert(s); + /* Returns 0 if the control PID is dead, > 0 if it is good. We never actually return < 0 here, but in order to + * make this function as similar as possible to main_pid_good() and cgroup_good(), we pretend that < 0 also + * means: we can't figure it out. */ + return s->control_pid > 0; } @@ -1433,6 +1437,9 @@ static int cgroup_good(Service *s) { assert(s); + /* Returns 0 if the cgroup is empty or doesn't exist, > 0 if it is exists and is populated, < 0 if we can't + * figure it out */ + if (!UNIT(s)->cgroup_path) return 0; -- 2.47.3