From 078fa35c7bd7e7392b07e032297a341fef695c42 Mon Sep 17 00:00:00 2001 From: Rich Salz Date: Tue, 20 Apr 2021 11:21:13 -0400 Subject: [PATCH] Remove an unused parameter Reviewed-by: Matthias St. Pierre Reviewed-by: Tomas Mraz (Merged from https://github.com/openssl/openssl/pull/14943) --- apps/cms.c | 2 +- crypto/cms/cms_ess.c | 4 ++-- doc/man3/CMS_get1_ReceiptRequest.pod | 6 +++--- include/openssl/cms.h.in | 2 +- 4 files changed, 7 insertions(+), 7 deletions(-) diff --git a/apps/cms.c b/apps/cms.c index 6285c5bf724..ed349bda2da 100644 --- a/apps/cms.c +++ b/apps/cms.c @@ -1413,7 +1413,7 @@ static CMS_ReceiptRequest *make_receipt_request( rct_from = NULL; } rr = CMS_ReceiptRequest_create0_ex(NULL, -1, rr_allorfirst, rct_from, - rct_to, libctx, app_get0_propq()); + rct_to, libctx); return rr; err: sk_GENERAL_NAMES_pop_free(rct_to, GENERAL_NAMES_free); diff --git a/crypto/cms/cms_ess.c b/crypto/cms/cms_ess.c index b713581c05f..ba78b6ebad4 100644 --- a/crypto/cms/cms_ess.c +++ b/crypto/cms/cms_ess.c @@ -63,7 +63,7 @@ int ossl_cms_check_signing_certs(const CMS_SignerInfo *si, CMS_ReceiptRequest *CMS_ReceiptRequest_create0_ex( unsigned char *id, int idlen, int allorfirst, STACK_OF(GENERAL_NAMES) *receiptList, STACK_OF(GENERAL_NAMES) *receiptsTo, - OSSL_LIB_CTX *libctx, const char *propq) + OSSL_LIB_CTX *libctx) { CMS_ReceiptRequest *rr; @@ -106,7 +106,7 @@ CMS_ReceiptRequest *CMS_ReceiptRequest_create0( STACK_OF(GENERAL_NAMES) *receiptList, STACK_OF(GENERAL_NAMES) *receiptsTo) { return CMS_ReceiptRequest_create0_ex(id, idlen, allorfirst, receiptList, - receiptsTo, NULL, NULL); + receiptsTo, NULL); } int CMS_add1_ReceiptRequest(CMS_SignerInfo *si, CMS_ReceiptRequest *rr) diff --git a/doc/man3/CMS_get1_ReceiptRequest.pod b/doc/man3/CMS_get1_ReceiptRequest.pod index 94ecfa6acb0..972345fce88 100644 --- a/doc/man3/CMS_get1_ReceiptRequest.pod +++ b/doc/man3/CMS_get1_ReceiptRequest.pod @@ -13,7 +13,7 @@ CMS_add1_ReceiptRequest, CMS_get1_ReceiptRequest, CMS_ReceiptRequest_get0_values CMS_ReceiptRequest *CMS_ReceiptRequest_create0_ex( unsigned char *id, int idlen, int allorfirst, STACK_OF(GENERAL_NAMES) *receiptList, STACK_OF(GENERAL_NAMES) *receiptsTo, - OSSL_LIB_CTX *libctx, const char *propq); + OSSL_LIB_CTX *libctx); CMS_ReceiptRequest *CMS_ReceiptRequest_create0( unsigned char *id, int idlen, int allorfirst, STACK_OF(GENERAL_NAMES) *receiptList, STACK_OF(GENERAL_NAMES) *receiptsTo); @@ -33,11 +33,11 @@ If I is NULL the allOrFirstTier option in I is used and set to the value of the I parameter. If I is not NULL the I option in I is used. The I parameter specifies the I field value. The library context I -and the property query I are used when retrieving algorithms from providers. +is used to find the public random generator. CMS_ReceiptRequest_create0() is similar to CMS_ReceiptRequest_create0_ex() but uses default values of NULL for the -library context I and the property query I. +library context I. The CMS_add1_ReceiptRequest() function adds a signed receipt request B to SignerInfo structure B. diff --git a/include/openssl/cms.h.in b/include/openssl/cms.h.in index ba86ad1cab4..451191b7967 100644 --- a/include/openssl/cms.h.in +++ b/include/openssl/cms.h.in @@ -343,7 +343,7 @@ CMS_ReceiptRequest *CMS_ReceiptRequest_create0_ex( unsigned char *id, int idlen, int allorfirst, STACK_OF(GENERAL_NAMES) *receiptList, STACK_OF(GENERAL_NAMES) *receiptsTo, - OSSL_LIB_CTX *ctx, const char *propq); + OSSL_LIB_CTX *ctx); int CMS_add1_ReceiptRequest(CMS_SignerInfo *si, CMS_ReceiptRequest *rr); void CMS_ReceiptRequest_get0_values(CMS_ReceiptRequest *rr, -- 2.47.2