From 07d2098890e9113079bae64f6fc7f4069f7b12cd Mon Sep 17 00:00:00 2001 From: Mark Wielaard Date: Wed, 6 Jun 2018 23:35:35 +0200 Subject: [PATCH] tests: Use error, not assert, when trying to print a non-base type DIE. When using the varlocs test with a fuzzer using assert for internal sanity checks is great to find issues. But when encountering bad data using an assert is wrong. Just use error to show we handle the data correctly (by reporting it is bad, instead of crashing). Signed-off-by: Mark Wielaard --- tests/ChangeLog | 5 +++++ tests/varlocs.c | 3 ++- 2 files changed, 7 insertions(+), 1 deletion(-) diff --git a/tests/ChangeLog b/tests/ChangeLog index a7b8da72b..587e2ac9b 100644 --- a/tests/ChangeLog +++ b/tests/ChangeLog @@ -1,3 +1,8 @@ +2018-06-06 Mark Wielaard + + * varlocs.c (print_base_type): Use error, not assert when the DIE + isn't a base type. + 2018-06-02 Mark Wielaard * test-subr.sh (self_test_files_exe): Drop shared libraries. diff --git a/tests/varlocs.c b/tests/varlocs.c index 31a1069a9..2ddd3d8f3 100644 --- a/tests/varlocs.c +++ b/tests/varlocs.c @@ -122,7 +122,8 @@ dwarf_form_string (unsigned int form) static void print_base_type (Dwarf_Die *base) { - assert (dwarf_tag (base) == DW_TAG_base_type); + if (dwarf_tag (base) != DW_TAG_base_type) + error (EXIT_FAILURE, 0, "not a base type"); Dwarf_Attribute encoding; Dwarf_Word enctype = 0; -- 2.47.2