From 08644d068609dc7bdca008cf76a285c441225650 Mon Sep 17 00:00:00 2001 From: Stefano Lattarini Date: Tue, 22 May 2012 22:37:34 +0200 Subject: [PATCH] [ng] cosmetics: improve comments and spacing in 'parallel-tests.am' * lib/am/parallel-tests.am: Fix some comment typos and missing capitalization; improve clarity through more use of vertical spacing; add a coupe of explicative comments. Signed-off-by: Stefano Lattarini --- lib/am/parallel-tests.am | 12 +++++++++--- 1 file changed, 9 insertions(+), 3 deletions(-) diff --git a/lib/am/parallel-tests.am b/lib/am/parallel-tests.am index 223063fa2..4f2e003a4 100644 --- a/lib/am/parallel-tests.am +++ b/lib/am/parallel-tests.am @@ -71,29 +71,35 @@ am__tpfx = \ $(if $1,$(call am__toupper,$(patsubst .%,%_,$1))) !define am__handle_per_suffix_test +! +## FIXME: This will pick up the default from the environment; are we sure +## FIXME: we want that? !$$(call am__tpfx,$1)LOG_DRIVER ?= $(SHELL) $(am__config_aux_dir)/test-driver +! !%.log %.trs: %$1 $$($$(call am__tpfx,$1)LOG_DEPENDENCIES) ! @$$(call am__runtest,$$(call am__tpfx,$1)) +! !ifeq ($(am__handle_exeext),yes) !ifdef EXEEXT !%.log %.trs: %$1$(EXEEXT) $$($$(call am__tpfx,$1)LOG_DEPENDENCIES) ! @$$(call am__runtest,$$(call am__tpfx,$1)) !endif # defined EXEEXT !endif # am__handle_exeext = yes -!endef +! +!endef # am__handle_per_suffix_test ! ## FIXME: this will pick up the default from the environment; are we sure ## FIXME: we want that? !TEST_EXTENSIONS ?= .test !$(call am__maybe_invalid_test_extensions,$(filter-out .%,$(TEST_EXTENSIONS))) -## FIXME: it would be nice to break these on multiple lines. Unfortnately, +## FIXME: it would be nice to break these on multiple lines. Unfortunately, ## FIXME: our '!' is not yet smart enough to handle that :-( !$(foreach am__e,$(TEST_EXTENSIONS), $(eval $(call am__handle_per_suffix_test,$(am__e)))) ## It is *imperative* that the "empty" suffix goes last. Otherwise, a ## declaration like "TESTS = all.test" would cause GNU make to mistakenly ## try to build the 'all.log' and 'all.trs' files from a non-existent ## 'all' program (because the Makefile contains an explicit 'all' target, -## albeith .PHONY), rather than from the 'all.test' script, thus causing +## albeit .PHONY), rather than from the 'all.test' script, thus causing ## all sort of mishaps and confusion. !$(eval $(call am__handle_per_suffix_test)) -- 2.47.2